Page Comparison

...

1. If you run the tests before 8pm you should see the message Ready to process the data. If you change the time at line 20 to an hour before you are running the code, the message will not be displayed. This is not a suitable way to test if this code actually works as expected.

2. Refactoring the code and writing a new test to support the refactored code - read Activity 1 Observations

   1. Refactor the code so that the FileLog is injected into the DataClerk

   2. Decide how you can test it to verify that the code is still working.

   3. Give attention to whether you should be injecting the class or an interface

   4. Use the mockito doNothing().when() (or a library you are familiar with that has the same capabilities) feature to set up an expectation that can be used to verify when DataClerk.clearLog() is being called

3. Line 22 is an issue. The timestamp is hard coded. Not a problem you say. We can remove the magic number so it’s declared as a constant field in the class. This doesn’t really help us because we can only test alternative paths after 8pm. We can use a Spy mechanism to solve this. This can be done by refactoring the code so that the current time is returned from a private method in the DataClerk class.

   1. Turn line 19 into a private function

   2. Use the private package level function to get the time

   3. In the test use mockito spy to override the returned time so it is greater than 2000 hours.

   4. Code Block
      Mockito.doReturn(LocalTime.parse("21:00")).when(cutSpy).getTime();

4. An alternative design for activity 2 would be to use a lambda expression in line 22

   1. Think about how this might work, and what would the test look like?

...